Not logged in. · Lost password · Register
Forum: Features request RSS
Easy Album Art
Page:  previous  1  2 
Avatar
Azimuth #16
Member since Jan 2003 · 427 posts · Location: Chicago, Illinois - USA
Group memberships: Members
Show profile · Link to this post
WWWinamp screenshot... http://home.earthlink.net/~tonyno/wwwinamp.jpg
selsrog #17
Member since Jun 2003 · 4 posts
Group memberships: Members
Show profile · Link to this post
So we have to convince Henry to include this feature in BA2, no?  :-p
Avatar
Azimuth #18
Member since Jan 2003 · 427 posts · Location: Chicago, Illinois - USA
Group memberships: Members
Show profile · Link to this post
It is already there, but, mine is broken for some reason! There has to be something wrong somewhere...
SteveB #19
Member since Apr 2003 · 29 posts
Group memberships: Members
Show profile · Link to this post
Hi. I've finally made the switch the BrowseAmp 2 and it's fantastic - what took me so long?!

I've been playing with this album art stuff, which is great when it works but the trouble (for me) is that it doesn't seem to work all the time.

My MP3s are in folders like "Artist - Album". Each folder contains MP3s, a playlist, and a cover.jpg file. If I load the playlists, the cover art displays fine.

I also have a directory structure containing only playlists sorted by genre that link back to the files above (using the same drive letter) e.g. !playlists\rock\Pink Floyd - The Wall CD1.m3u. If I load one of these playlists the cover art doesn't display.

I had a look at the IMG tag in the page source to see what's wrong. The only difference is that in the tag that works the drive letter is upper case, and in the one that doesn't work it's lower case e.g.

<img src="cover.jpg?src=M:\Dreamland" width="100"> (works)
<img src="cover.jpg?src=m:\Dreamland" width="100"> (doesn't work)

I guess I could use some JavaScript to convert the drive letters to upper case but I'm not really sure that's the right approach. Could this be a bug?

Thanks,
Steve

PS Azimuth - I like your TTunes skin!
Avatar
Henry (Administrator) #20
Member since Jan 2003 · 865 posts · Location: Munich Germany
Group memberships: Administrators, Members
Show profile · Link to this post
Could this be a bug?
Well... yes!  :whistling:
Big thanks for the hint. I have just fixed it and I really apologize for that.

I attached the fixed DLL(2.04 beta) so you can test it.


@Azimuth
Maybe that is the same reason for your problems with cover art.
The author has attached one file to this post:
gen_brow2.dll 847.5 kBytes
You have no permission to open this file.
SteveB #21
Member since Apr 2003 · 29 posts
Group memberships: Members
Show profile · Link to this post
WOW! Now that's what I call quick service ;)

Yep, that's fixed it - thanks Henry.

Am I right in thinking it's by design that it doesn't work if the playlist refers to a drive other than the BrowseAmp's root? e.g. if I store my playlists on Q: drive and they list files on M: drive? (Which I do, but I'm sure I can work round that :) )

BTW - "SteveB edition" - my very own edition of BrowseAmp! lol  :-D

Thanks again

Steve
Avatar
Henry (Administrator) #22
Member since Jan 2003 · 865 posts · Location: Munich Germany
Group memberships: Administrators, Members
Show profile · Link to this post
WOW! Now that's what I call quick service
Yes, it was a good occupation to wake up in the morning.

Am I right in thinking it's by design that it doesn't work if the playlist refers to a drive other than the BrowseAmp's root?
Yes you are right again! I only allow src=pathtoafile to be located under the MP3 root directory of the current user. That is because of security reasons. If I'd allow all sources someone would be able to read your private data with a command like: http://yourserver:8080/notepad.exe?src=c:\winnt (stupid example, I know...).
SteveB #23
Member since Apr 2003 · 29 posts
Group memberships: Members
Show profile · Link to this post
Yes, makes sense. How about making it configurable in the properties screen so you could enable/disable access to files outside the root folder?

Cheers,
Steve
Avatar
Henry (Administrator) #24
Member since Jan 2003 · 865 posts · Location: Munich Germany
Group memberships: Administrators, Members
Show profile · Link to this post
Ok, maybe in a future release.
Close Smaller – Larger + Reply to this post:
Verification code: VeriCode Please enter the word from the image into the text field below. (Type the letters only, lower case is okay.)
Smileys: :-) ;-) :-D :-p :blush: :cool: :rolleyes: :huh: :-/ <_< :-( :'( :#: :scared: 8-( :nuts: :-O
Special characters:
Page:  previous  1  2 
Go to forum
This board is powered by the Unclassified NewsBoard software, 20150713-dev, © 2003-2015 by Yves Goergen
Page created in 186.7 ms (72.6 ms) · 80 database queries in 53.9 ms
Current time: 2018-07-21, 17:14:29 (UTC +00:00)